mikkel/nexus
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(plugins): address Greptile feedback on testing.ts

Browse source 
Remove unnecessary `as any` casts on capability strings (now valid
PluginCapability members) and add company-membership guards to match
production behavior in plugin-host-services.ts.
This commit is contained in:
Justin Miller 2026-03-16 16:01:00 -06:00
parent 0d4dd50b35
commit 56985a320f
1 changed files with 18 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
packages/plugins/sdk/src/testing.ts
View file

@ -423,20 +423,30 @@ export function createTestHarness(options: TestHarnessOptions): TestHarness {
return comment;
},
documents: {
async list(_issueId, _companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.read" as any);
async list(issueId, companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.read");
if (!isInCompany(issues.get(issueId), companyId)) return [];
return [];
},
async get(_issueId, _key, _companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.read" as any);
async get(issueId, _key, companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.read");
if (!isInCompany(issues.get(issueId), companyId)) return null;
return null;
},
async upsert(_input) {
requireCapability(manifest, capabilitySet, "issue.documents.write" as any);
async upsert(input) {
requireCapability(manifest, capabilitySet, "issue.documents.write");
const parentIssue = issues.get(input.issueId);
if (!isInCompany(parentIssue, input.companyId)) {
throw new Error(`Issue not found: ${input.issueId}`);
}
throw new Error("documents.upsert is not implemented in test context");
},
async delete(_issueId, _key, _companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.write" as any);
async delete(issueId, _key, companyId) {
requireCapability(manifest, capabilitySet, "issue.documents.write");
const parentIssue = issues.get(issueId);
if (!isInCompany(parentIssue, companyId)) {
throw new Error(`Issue not found: ${issueId}`);
}
},
},
},