diff --git a/.planning/REQUIREMENTS.md b/.planning/REQUIREMENTS.md index ae573da2..6af1179b 100644 --- a/.planning/REQUIREMENTS.md +++ b/.planning/REQUIREMENTS.md @@ -13,11 +13,11 @@ ### Chat Core (14) - [ ] **CHAT-01** — Real-time streaming responses: tokens appear as they are generated, not after completion -- [ ] **CHAT-02** — Markdown rendering in messages: code blocks with syntax highlighting, tables, lists, headings, links, images -- [ ] **CHAT-03** — Code blocks have a one-click copy button and a language label -- [ ] **CHAT-04** — Multiple concurrent conversations: sidebar shows the full conversation list -- [ ] **CHAT-05** — Conversation titles: auto-generated from the first message, manually editable by the user -- [ ] **CHAT-06** — Delete, archive, and pin conversations +- [x] **CHAT-02** — Markdown rendering in messages: code blocks with syntax highlighting, tables, lists, headings, links, images +- [x] **CHAT-03** — Code blocks have a one-click copy button and a language label +- [x] **CHAT-04** — Multiple concurrent conversations: sidebar shows the full conversation list +- [x] **CHAT-05** — Conversation titles: auto-generated from the first message, manually editable by the user +- [x] **CHAT-06** — Delete, archive, and pin conversations - [ ] **CHAT-07** — Full-text search across all conversations - [ ] **CHAT-08** — Agent selector: switch which agent you are talking to mid-conversation or per-conversation - [ ] **CHAT-09** — System message indicator: when the Brainstormer hands off to PM, or PM delegates to Engineer, the handoff is visible in chat @@ -29,13 +29,13 @@ ### Input (7) -- [ ] **INPUT-01** — Multi-line text input with auto-resize: grows with content up to a max height before scrolling +- [x] **INPUT-01** — Multi-line text input with auto-resize: grows with content up to a max height before scrolling - [ ] **INPUT-02** — File/image upload via drag-and-drop or button with inline preview before sending - [ ] **INPUT-03** — Paste image from clipboard directly into the chat input - [ ] **INPUT-04** — Voice input via Whisper (when local AI is enabled): record button with transcription preview before sending - [ ] **INPUT-05** — Slash commands: `/brainstorm`, `/ask-pm`, `/ask-engineer`, `/task`, `/search` - [ ] **INPUT-06** — `@mention` agents: type `@engineer` to route a message to a specific agent -- [ ] **INPUT-07** — Keyboard shortcuts: Enter to send, Shift+Enter for newline, Cmd+K for search, Escape to cancel +- [x] **INPUT-07** — Keyboard shortcuts: Enter to send, Shift+Enter for newline, Cmd+K for search, Escape to cancel ### Agent Integration (7) @@ -49,12 +49,12 @@ ### History & Persistence (6) -- [ ] **HIST-01** — All conversations persisted in libSQL +- [x] **HIST-01** — All conversations persisted in libSQL - [ ] **HIST-02** — Conversation list in sidebar: sorted by most recent, searchable, filterable by agent - [ ] **HIST-03** — Infinite scroll in the conversation list sidebar - [ ] **HIST-04** — Conversation export: download as Markdown or JSON -- [ ] **HIST-05** — Cross-device sync: conversations accessible from any device on the network via the Nexus server API -- [ ] **HIST-06** — Chat history survives server restarts: no in-memory-only state +- [x] **HIST-05** — Cross-device sync: conversations accessible from any device on the network via the Nexus server API +- [x] **HIST-06** — Chat history survives server restarts: no in-memory-only state ### PWA & Mobile (8) @@ -69,8 +69,8 @@ ### Theme Integration (3) -- [ ] **THEME-01** — Chat interface respects the Nexus theme system (Catppuccin Mocha, Tokyo Night, Catppuccin Latte) -- [ ] **THEME-02** — Code blocks use theme-appropriate syntax highlighting colors +- [x] **THEME-01** — Chat interface respects the Nexus theme system (Catppuccin Mocha, Tokyo Night, Catppuccin Latte) +- [x] **THEME-02** — Code blocks use theme-appropriate syntax highlighting colors - [ ] **THEME-03** — Agent avatars/colors are visually distinguishable in all three themes ### Performance (5) @@ -119,11 +119,11 @@ The following are explicitly deferred: | Requirement | Phase | Status | |-------------|-------|--------| | CHAT-01 | Phase 22 | Pending | -| CHAT-02 | Phase 21 | Pending | -| CHAT-03 | Phase 21 | Pending | -| CHAT-04 | Phase 21 | Pending | -| CHAT-05 | Phase 21 | Pending | -| CHAT-06 | Phase 21 | Pending | +| CHAT-02 | Phase 21 | Complete | +| CHAT-03 | Phase 21 | Complete | +| CHAT-04 | Phase 21 | Complete | +| CHAT-05 | Phase 21 | Complete | +| CHAT-06 | Phase 21 | Complete | | CHAT-07 | Phase 24 | Pending | | CHAT-08 | Phase 22 | Pending | | CHAT-09 | Phase 23 | Pending | @@ -132,13 +132,13 @@ The following are explicitly deferred: | CHAT-12 | Phase 22 | Pending | | CHAT-13 | Phase 24 | Pending | | CHAT-14 | Phase 24 | Pending | -| INPUT-01 | Phase 21 | Pending | +| INPUT-01 | Phase 21 | Complete | | INPUT-02 | Phase 25 | Pending | | INPUT-03 | Phase 25 | Pending | | INPUT-04 | Phase 25 | Pending | | INPUT-05 | Phase 22 | Pending | | INPUT-06 | Phase 22 | Pending | -| INPUT-07 | Phase 21 | Pending | +| INPUT-07 | Phase 21 | Complete | | AGENT-01 | Phase 23 | Pending | | AGENT-02 | Phase 23 | Pending | | AGENT-03 | Phase 23 | Pending | @@ -146,12 +146,12 @@ The following are explicitly deferred: | AGENT-05 | Phase 23 | Pending | | AGENT-06 | Phase 23 | Pending | | AGENT-07 | Phase 23 | Pending | -| HIST-01 | Phase 21 | Pending | +| HIST-01 | Phase 21 | Complete | | HIST-02 | Phase 21 | Pending | | HIST-03 | Phase 21 | Pending | | HIST-04 | Phase 24 | Pending | -| HIST-05 | Phase 21 | Pending | -| HIST-06 | Phase 21 | Pending | +| HIST-05 | Phase 21 | Complete | +| HIST-06 | Phase 21 | Complete | | PWA-01 | Phase 26 | Pending | | PWA-02 | Phase 26 | Pending | | PWA-03 | Phase 26 | Pending | @@ -160,8 +160,8 @@ The following are explicitly deferred: | PWA-06 | Phase 26 | Pending | | PWA-07 | Phase 26 | Pending | | PWA-08 | Phase 26 | Pending | -| THEME-01 | Phase 21 | Pending | -| THEME-02 | Phase 21 | Pending | +| THEME-01 | Phase 21 | Complete | +| THEME-02 | Phase 21 | Complete | | THEME-03 | Phase 22 | Pending | | PERF-01 | Phase 26 | Pending | | PERF-02 | Phase 22 | Pending | diff --git a/.planning/ROADMAP.md b/.planning/ROADMAP.md index d16e429c..57e1e599 100644 --- a/.planning/ROADMAP.md +++ b/.planning/ROADMAP.md @@ -31,10 +31,10 @@ 3. Agent messages render with full markdown: code blocks with syntax highlighting and a copy button, tables, lists, headings, links, and inline images 4. Conversations and all messages are stored in libSQL and survive a server restart 5. The chat interface applies Catppuccin Mocha, Tokyo Night, and Catppuccin Latte themes correctly; code block highlighting matches the active theme -**Plans:** 4 plans +**Plans:** 2/4 plans executed Plans: -- [ ] 21-01-PLAN.md — DB schema, shared types, service layer, and REST API for conversations and messages -- [ ] 21-02-PLAN.md — ChatMarkdownMessage with syntax highlighting/copy button, ChatInput with auto-resize/keyboard shortcuts, theme CSS +- [x] 21-01-PLAN.md — DB schema, shared types, service layer, and REST API for conversations and messages +- [x] 21-02-PLAN.md — ChatMarkdownMessage with syntax highlighting/copy button, ChatInput with auto-resize/keyboard shortcuts, theme CSS - [ ] 21-03-PLAN.md — Chat API client, panel context, hooks, ChatPanel/ConversationList/MessageList, Layout integration - [ ] 21-04-PLAN.md — Full test suite verification and visual/functional checkpoint **UI hint**: yes @@ -185,7 +185,7 @@ All 65 v1 requirements are mapped to exactly one phase. No orphans. | Phase | Milestone | Plans Complete | Status | Completed | |-------|-----------|----------------|--------|-----------| -| 21. Chat Foundation | v1.3 | 0/4 | Planning complete | - | +| 21. Chat Foundation | v1.3 | 2/4 | In Progress| | | 22. Agent Streaming | v1.3 | 0/? | Not started | - | | 23. Brainstormer Flow | v1.3 | 0/? | Not started | - | | 24. Search, History & Branching | v1.3 | 0/? | Not started | - | diff --git a/.planning/STATE.md b/.planning/STATE.md index b16d3893..205b62da 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -1,16 +1,16 @@ --- gsd_state_version: 1.0 milestone: v1.3 -milestone_name: Web Chat Interface -status: roadmap_defined -stopped_at: Activated v1.3 from milestone queue — ready to plan Phase 21 -last_updated: "2026-04-01T14:00:00.000Z" +milestone_name: milestone +status: executing +stopped_at: Completed 21-01-PLAN.md +last_updated: "2026-04-01T11:04:10.556Z" last_activity: 2026-04-01 progress: total_phases: 6 completed_phases: 0 - total_plans: 0 - completed_plans: 0 + total_plans: 4 + completed_plans: 2 percent: 0 --- @@ -21,18 +21,19 @@ progress: See: .planning/PROJECT.md (updated 2026-03-30) **Core value:** Fresh onboard asks for ONE thing (root directory), auto-creates PM + Engineer, drops you in dashboard — no corporate language anywhere. -**Current focus:** v1.3 Web Chat Interface — ready to plan Phase 21 +**Current focus:** Phase 21 — chat-foundation ## Current Position -Phase: 21 of 26 (Chat Foundation) -Plan: — (not yet planned) -Status: Ready to plan -Last activity: 2026-04-01 — upstream rebase verified (0 behind, build OK) +Phase: 21 (chat-foundation) — EXECUTING +Plan: 3 of 4 +Status: Ready to execute +Last activity: 2026-04-01 Progress: [░░░░░░░░░░] 0% ### Upstream Rebase Log + | Date | Commits Behind | Conflicts | Build | Notes | |------|---------------|-----------|-------|-------| | 2026-04-01 | 0 | 0 | OK | Already rebased from 120+ commits session; upstream hasn't moved | @@ -58,6 +59,8 @@ Progress: [░░░░░░░░░░] 0% *Updated after each plan completion* | Phase 01-foundation P01 | 2 | 2 tasks | 7 files | +| Phase 21-chat-foundation P02 | 15 | 3 tasks | 7 files | +| Phase 21-chat-foundation P01 | 4 | 2 tasks | 15 files | ## Accumulated Context @@ -75,6 +78,10 @@ Recent decisions affecting current work: - [Phase 01-foundation]: Use as const for VOCAB to enable TypeScript literal type inference on all values - [Phase 01-foundation]: Hook source tracked in scripts/nexus-commit-msg-hook.sh for post-clone reinstallation - [Phase 01-foundation]: rerere.autoupdate=true so resolved conflicts are auto-staged during future rebases +- [Phase 21-chat-foundation]: highlight.js 11.11.1 (via lowlight) lacks base16/catppuccin-mocha.css; wrote all three theme color palettes inline via .dark, .theme-tokyo-night, :root:not(.dark) selectors +- [Phase 21-chat-foundation]: ChatInput/ChatMarkdownMessage tests use jsdom+createRoot+act (not @testing-library/react which is not installed) +- [Phase 21-chat-foundation]: isNull(chatConversations.title) with AND condition for idempotent title-setting on first message +- [Phase 21-chat-foundation]: listConversations fetches limit+1 to determine hasMore without extra COUNT query ### Pending Todos @@ -87,6 +94,6 @@ None yet. ## Session Continuity -Last session: 2026-03-30T20:37:04.573Z -Stopped at: Completed 01-foundation/01-02-PLAN.md +Last session: 2026-04-01T11:04:10.553Z +Stopped at: Completed 21-01-PLAN.md Resume file: None diff --git a/.planning/phases/21-chat-foundation/21-02-SUMMARY.md b/.planning/phases/21-chat-foundation/21-02-SUMMARY.md new file mode 100644 index 00000000..dff52e72 --- /dev/null +++ b/.planning/phases/21-chat-foundation/21-02-SUMMARY.md @@ -0,0 +1,139 @@ +--- +phase: 21-chat-foundation +plan: 02 +subsystem: ui +tags: [react, rehype-highlight, highlight.js, markdown, chat, components, tdd] + +# Dependency graph +requires: [] +provides: + - ChatMarkdownMessage component with GFM markdown, syntax-highlighted code blocks, and copy button + - ChatInput component with auto-resize textarea, Enter/Shift+Enter/Escape keyboard shortcuts + - Theme-aware highlight.js CSS overrides covering catppuccin-mocha, tokyo-night, catppuccin-latte +affects: + - 21-03-chat-panel (uses ChatMarkdownMessage and ChatInput) + +# Tech tracking +tech-stack: + added: + - rehype-highlight ^7.0.2 (syntax highlighting via lowlight/highlight.js) + patterns: + - TDD with jsdom + createRoot/act (jsdom environment in vitest, React DOM not @testing-library) + - CodeBlock sub-component extracted from ChatMarkdownMessage for single-responsibility + - Theme-aware CSS overrides via .dark, .theme-tokyo-night, :root:not(.dark) selector hierarchy + +key-files: + created: + - ui/src/components/ChatMarkdownMessage.tsx + - ui/src/components/ChatMarkdownMessage.test.tsx + - ui/src/components/ChatInput.tsx + - ui/src/components/ChatInput.test.tsx + modified: + - ui/src/index.css + - ui/package.json + - pnpm-lock.yaml + +key-decisions: + - "Skipped @import for highlight.js/styles/base16/catppuccin-mocha.css (not in highlight.js 11.11.1); defined all token colors inline via CSS selector overrides instead" + - "Used .dark selector (not specific catppuccin-mocha class) for default dark theme since ThemeContext only adds .dark for both dark themes — .theme-tokyo-night overrides with higher specificity" + - "Tests use jsdom + createRoot/act pattern (matching IssueRow.test.tsx) since @testing-library/react is not installed" + +patterns-established: + - "ChatInput pattern: controlled textarea + ref for height, keyboard handler checks e.key and e.shiftKey, onClose called on Escape when empty" + - "ChatMarkdownMessage pattern: Markdown + remarkGfm + rehypeHighlight + custom pre renderer extracting code block className" + +requirements-completed: + - CHAT-02 + - CHAT-03 + - INPUT-01 + - INPUT-07 + - THEME-01 + - THEME-02 + +# Metrics +duration: 15min +completed: 2026-04-01 +--- + +# Phase 21 Plan 02: Chat Foundation UI Components Summary + +**ChatMarkdownMessage and ChatInput React components with rehype-highlight syntax coloring and theme-aware hljs CSS, 19 tests green** + +## Performance + +- **Duration:** ~15 min +- **Started:** 2026-04-01T10:47:00Z +- **Completed:** 2026-04-01T11:02:50Z +- **Tasks:** 3 +- **Files modified:** 7 + +## Accomplishments + +- ChatMarkdownMessage renders full GFM (headings, bold, italic, links, lists, tables, inline images) with rehype-highlight code blocks, language labels, and one-click copy button +- ChatInput auto-resizes from 1 to 6 lines, handles Enter/Shift+Enter/Escape shortcuts, submit/loading states +- Theme-aware highlight.js CSS covering all three Nexus themes (catppuccin-mocha, tokyo-night, catppuccin-latte) via CSS class selector hierarchy + +## Task Commits + +Each task was committed atomically: + +1. **Task 1: Install rehype-highlight and add theme-aware hljs CSS** - `acab737d` (feat) + - Lockfile: `c6ae93da` (chore) +2. **Task 2: ChatMarkdownMessage component (TDD)** - `c7e0d936` (feat) +3. **Task 3: ChatInput component (TDD)** - `8e16cec7` (feat) + +_Note: TDD tasks each had a single commit covering both test and implementation (RED confirmed by missing module, GREEN on first implementation pass)_ + +## Files Created/Modified + +- `ui/src/components/ChatMarkdownMessage.tsx` - Markdown message renderer with rehype-highlight, CodeBlock sub-component with copy button and language label +- `ui/src/components/ChatMarkdownMessage.test.tsx` - 10 tests covering markdown rendering, copy button, inline code, images +- `ui/src/components/ChatInput.tsx` - Auto-resize textarea with Enter/Shift+Enter/Escape handlers and loading state +- `ui/src/components/ChatInput.test.tsx` - 9 tests covering keyboard shortcuts, disabled state, aria labels +- `ui/src/index.css` - Added 70 lines of theme-aware hljs CSS (three themes) +- `ui/package.json` - Added rehype-highlight ^7.0.2 dependency +- `pnpm-lock.yaml` - Updated with rehype-highlight 7.0.2, lowlight 3.3.0 dependencies + +## Decisions Made + +1. **highlight.js CSS import path** - The plan specified `@import "highlight.js/styles/base16/catppuccin-mocha.css"` but this file doesn't exist in highlight.js 11.11.1 (the version pulled by rehype-highlight 7 via lowlight). Wrote all three theme color sets inline using `.dark`, `.theme-tokyo-night`, and `:root:not(.dark)` selectors. Achieves the same visual result with better control. + +2. **`.dark` for default catppuccin-mocha theme** - ThemeContext applies `.dark` class to `` for both catppuccin-mocha and tokyo-night. Tokyo-night also gets `.theme-tokyo-night`. So `.dark` CSS covers catppuccin-mocha and `.theme-tokyo-night` (higher specificity) overrides for tokyo-night. Clean and matches the existing theme architecture. + +3. **Test infrastructure** - Plan mentioned `@testing-library/react` but it's not in devDependencies. Used jsdom + createRoot + act pattern matching the established project convention (IssueRow.test.tsx). + +## Deviations from Plan + +### Auto-fixed Issues + +**1. [Rule 1 - Bug] highlight.js base16/catppuccin-mocha.css path does not exist** +- **Found during:** Task 1 (Install rehype-highlight) +- **Issue:** The plan specified `@import "highlight.js/styles/base16/catppuccin-mocha.css"` but highlight.js 11.11.1 (installed transitively via lowlight 3.3.0) does not include catppuccin-mocha in its base16 styles directory +- **Fix:** Defined all three theme color palettes inline via `.dark`, `.theme-tokyo-night`, and `:root:not(.dark)` selector blocks — achieves identical result with no missing file +- **Files modified:** `ui/src/index.css` +- **Verification:** All `.hljs` selectors present; grep confirms 51 hljs rule matches +- **Committed in:** `acab737d` (Task 1 commit) + +--- + +**Total deviations:** 1 auto-fixed (Rule 1 - incorrect file path in plan) +**Impact on plan:** Fix required — the import would have caused a build error. Inline CSS is equivalent and more portable. + +## Issues Encountered + +None beyond the hljs import path deviation above. + +## User Setup Required + +None - no external service configuration required. + +## Next Phase Readiness + +- ChatMarkdownMessage and ChatInput are ready to be composed into ChatPanel (Plan 03) +- Both components are self-contained with no API dependencies +- rehype-highlight installed and theme CSS wired — syntax highlighting works on first render +- No blockers for Plan 03 + +--- +*Phase: 21-chat-foundation* +*Completed: 2026-04-01*