From f0182ff42ca702808550bcc0106ce1458be3b5f8 Mon Sep 17 00:00:00 2001 From: Nexus Dev Date: Sat, 11 Apr 2026 17:25:22 +0000 Subject: [PATCH] docs(nexus): mark full design system migration as complete --- CODEBASE-MAP.md | 22 ++++++++++------ PROJECT-STATUS.md | 64 +++++++++++++++++++++++------------------------ 2 files changed, 46 insertions(+), 40 deletions(-) diff --git a/CODEBASE-MAP.md b/CODEBASE-MAP.md index 219eefbe..57f61cac 100644 --- a/CODEBASE-MAP.md +++ b/CODEBASE-MAP.md @@ -3,7 +3,7 @@ > **Purpose:** fast orientation for sessions that don't have the full conversation history loaded. This file is factual — generated by scanning the tree, not by reading intent docs. If something here contradicts a plan or spec, trust this file over the plans. > > **Branch:** `nexus/design-system-migration` -> **Last updated:** 2026-04-11 after **Wave 3B completion** (phases 16a and 16b DONE). Route map and component inventory rescanned against current `ui/src/App.tsx` and filesystem. 24 files deleted across 16a (7) + 16b (17). 294/294 tests passing. +> **Last updated:** 2026-04-11 after **full migration completion**. Phases 1–7 (visual repaint) + phases 8–16 (structural layout overhaul) + 3 post-Phase-7 polish follow-ups (F1/F2/F3) all DONE. 24 files deleted across 16a (7) + 16b (17) + 1 via F-series (`useInboxBadge.ts`). **304/304 tests passing** across 38 files. --- @@ -351,10 +351,13 @@ Unrelated to the design system migration, these have been flagged across review | 1 — Tokens + Inter font | **DONE** | `e49144a4` feat(nexus): design system phase 1 tokens and inter font | | 2 — Status + role color dictionaries | **DONE** | `4b8f8178` feat(nexus): design system phase 2 status and role color dictionaries | | 3 — Raw utility sweep | **DONE** | `3a41ec7b` feat(nexus): design system phase 3 raw utility sweep | -| 4 — Typography + radius audit | **PENDING** | No commits yet | -| 5 — ThemePreviewPanel rewrite | **PENDING** | No commits yet | -| 6 — hljs syntax highlighting | **PENDING** | No commits yet | -| 7 — Visual QA pass | **PENDING** | No commits yet | +| 4 — Typography + radius audit | **DONE** | `68c87fc8`, `16adf9f8`, `547e5262` — 57 radius collapses, 29 soft-shadow drops | +| 5 — ThemePreviewPanel rewrite | **DONE** | `0c1496d2`, `d3141ac5` — panel + palette grid restyled | +| 6 — hljs syntax highlighting | **DONE** | `f66209f4` — full hljs class coverage, 100% CSS-var references | +| 7 — Visual QA pass | **DONE** | `5ab0b19d` (audit doc) + `9329e5d9`, `862b856d`, `77edfdb4`, `bac89b1a` (inline fixes) | +| **F1** post-Phase-7 — brand color aliases | **DONE** | `c9ed4c92` — 7 files swapped from literal hexes | +| **F2** post-Phase-7 — shadow-xs shadcn cleanup | **DONE** | `044a2571` — 6 shadcn primitives | +| **F3** post-Phase-7 — DESIGN.md typography | **DONE** | `ec6c01b0` — Basier dropped, Inter-only | ### Layout overhaul phases 8–16 (structural) @@ -438,7 +441,10 @@ All 24 files in the 16a + 16b target list are confirmed deleted (verified via `l | `ui/src/components/InstanceSidebar.tsx` | 13 | | `ui/src/components/MobileBottomNav.tsx` | 15 | -### Residual cleanup targets (not deleted, flagged) +### Phase 7 cleanup (applied) -- `ui/src/hooks/useInboxBadge.ts` — orphaned after `Inbox.tsx` deletion, left intact (out of 16b scope). -- Dangling `/dashboard` hrefs in `SkillDetail.tsx`, `SkillBrowser.tsx`, `PluginManager.tsx`, `PluginSettings.tsx`, `PluginPage.tsx`, `NotFound.tsx`, `CompanyImport.tsx`, `ProjectDetail.tsx`, `AgentDetail.tsx`, `company-page-memory.ts`, `useCompanyPageMemory.ts` — now fall through to `NotFoundPage scope="board"`. Low-priority rewrite to `/assistant` or project-specific equivalents. +| File | Status | Phase | +|---|---|---| +| `ui/src/hooks/useInboxBadge.ts` | **DELETED** | 7 (follow-up `bac89b1a`) | + +All `/dashboard` hrefs across `SkillDetail.tsx`, `SkillBrowser.tsx`, `PluginManager.tsx`, `PluginSettings.tsx`, `PluginPage.tsx`, `NotFound.tsx`, `CompanyImport.tsx`, `ProjectDetail.tsx` (post-import navigate), `company-page-memory.ts`, and `useCompanyPageMemory.ts` were rewritten to `/assistant` in Phase 7 commit `862b856d`. Legitimate `/dashboard` survivors (plugin REST endpoints in `api/plugins.ts`, `api/dashboard.ts`, and live agent-tab routes in `AgentDetail.tsx:764,802`) are correct and intentional. diff --git a/PROJECT-STATUS.md b/PROJECT-STATUS.md index 981a153e..e9c79cf1 100644 --- a/PROJECT-STATUS.md +++ b/PROJECT-STATUS.md @@ -2,7 +2,7 @@ > **Purpose:** snapshot of where the project is right now — what's shipped, what's blocked, what to do next. Generated by scanning git log + code + reading `.planning/` and `docs/`. If this file disagrees with any plan or spec, trust this file; the code is the source of truth. > -> **Last updated:** 2026-04-11, **Wave 3B complete**. Phases 16a and 16b are both DONE and verified — 294/294 tests passing. The structural layout overhaul (phases 8–16) is fully shipped. Remaining scope on this branch is the visual repaint phases 4–7 and the Phase 11.5 backlog. +> **Last updated:** 2026-04-11, **full migration complete**. Phases 1–7 (visual repaint) and 8–16 (structural layout overhaul) are both DONE. Phase 7 audit applied + 3 polish follow-ups (F1/F2/F3) applied. **304/304 tests passing** across 38 files. Branch is ready to ship as a single thematic PR. --- @@ -43,12 +43,15 @@ Verified by `git log --oneline` on `nexus/design-system-migration`. | 1 | Foundation — `index.css` tokens + Inter font | **DONE** | `e49144a4` | | 2 | Status + role color dictionaries | **DONE** | `4b8f8178` | | 3 | Raw utility sweep | **DONE** | `3a41ec7b` | -| 4 | Typography + radius audit | **PENDING** | No commits | -| 5 | ThemePreviewPanel rewrite | **PENDING** | No commits | -| 6 | hljs syntax highlighting | **PENDING** | No commits | -| 7 | Visual QA pass | **PENDING** | No commits | +| 4 | Typography + radius audit | **DONE** | 3 commits `68c87fc8`, `16adf9f8`, `547e5262` — 57 radius collapses, 29 soft-shadow drops (1 kept: InstallPromptBanner), no display-weight bumps needed | +| 5 | ThemePreviewPanel rewrite | **DONE** | 2 commits `0c1496d2`, `d3141ac5` — panel rewritten against DESIGN.md palette, palette grid restyled (kept for theme-generation workshop) | +| 6 | hljs syntax highlighting | **DONE** | 1 commit `f66209f4` — 100% CSS-var references, 4-hue palette discipline, full hljs class coverage (66→111 LOC) | +| 7 | Visual QA pass | **DONE** | 5 commits `5ab0b19d` (audit doc) + `9329e5d9`, `862b856d`, `77edfdb4`, `bac89b1a` (inline fixes). Audit at `docs/reviews/2026-04-11-nexus-phase-7-visual-qa.md`. 0 blockers, 4 deviations, 12 follow-ups tracked. | +| **F1** | post-Phase-7 polish — brand color aliases | **DONE** | `c9ed4c92` — 7 files swapped from literal hexes to `bg-volt`/`bg-volt-pale`/`bg-forest`/`bg-silver` aliases | +| **F2** | post-Phase-7 polish — shadow-xs shadcn cleanup | **DONE** | `044a2571` — 6 shadcn primitives (select, input, textarea, toggle, checkbox, button) | +| **F3** | post-Phase-7 polish — DESIGN.md typography | **DONE** | `ec6c01b0` — Basier dropped, Inter-only confirmed in §3 + §9 | -**Note:** phases 4–7 are independent of the layout overhaul (phases 8–16) and can run before or after. The user explicitly chose to push the structural overhaul first because visual polish layers on top; the layout has bigger leverage. +**Note:** phases 4–7 shipped AFTER the structural overhaul (phases 8–16) per the user's sequencing decision — the layout overhaul had bigger leverage and the visual repaint layered cleanly on top. --- @@ -250,15 +253,15 @@ From `ui/src/App.tsx boardRoutes()`. Marks reflect the **post-Wave-3B** state. A ## 8. Pending decisions -### From MIGRATION-PLAN.md §10 — still unresolved for visual phases 4–7 +### From MIGRATION-PLAN.md §10 — all resolved -1. **Light mode:** ship / drop / iterate? Light mode tokens already exist in `index.css` (`:root` block) but the visual phases to validate them haven't run. -2. **Basier font:** license / Inter only / free alternative? Current state: Inter everywhere. Decision pending. -3. **Destructive color:** current dark is `#ef4444`, light is `#dc2626`. Effectively resolved via the shipped tokens. -4. **Role hue collapse vs preserve:** resolved — `--chart-role-1..5` exception documented in `index.css`. -5. **Display 900:** resolved — used in the 72px ProjectCard hero and 96px empty state. -6. **Theme toggle UX:** resolved — binary light/dark, toggle in Settings Workspace section. -7. **Tokyo Night removal:** resolved — deleted in Phase 1 commit. +1. **Light mode:** RESOLVED — shipped. Light-mode tokens in `index.css` `:root` validated via Phase 7 visual QA. Forest green downrank of volt in light mode works as designed. +2. **Basier font:** RESOLVED — **Inter only**. DESIGN.md §3 amended in follow-up F3 (commit `ec6c01b0`). +3. **Destructive color:** RESOLVED — `#ef4444` dark, `#dc2626` light, both shipped and audited. +4. **Role hue collapse vs preserve:** RESOLVED — `--chart-role-1..5` exception documented in `index.css`. +5. **Display 900:** RESOLVED — used in 72px ProjectCard hero and 96px Projects empty state (Phase 4 confirmed). +6. **Theme toggle UX:** RESOLVED — binary light/dark, toggle in Settings Workspace section. +7. **Tokyo Night removal:** RESOLVED — deleted in Phase 1 commit. ### From the layout overhaul @@ -279,35 +282,32 @@ From `ui/src/App.tsx boardRoutes()`. Marks reflect the **post-Wave-3B** state. A ## 9. Next actions (ordered) -The structural layout overhaul (phases 8–16) is complete. The remaining scope on this branch is the visual repaint tail and a backend-dependent backlog item. +**The `nexus/design-system-migration` branch is now complete.** Phases 1–7 (visual repaint) + phases 8–16 (structural layout overhaul) + 3 post-Phase-7 polish follow-ups are all DONE. 304/304 tests passing. DESIGN.md compliance audit has zero blockers. Ready for PR creation. -### Track A — Visual migration phases 4–7 (RECOMMENDED NEXT) +### Immediate -Pure frontend, no backend dependencies, unblocked. Recommended first because (a) it's the only remaining DESIGN.md compliance gap, (b) it completes the design system migration as a single thematic branch unit, and (c) the work is self-contained to ~3 files + one QA sweep. +1. **Create the PR** against `PAP-878-create-a-mine-tab-in-inbox`. The branch has ~70+ commits; the PR body should summarize the two overlapping tracks (visual repaint + structural overhaul) and link the audit doc at `docs/reviews/2026-04-11-nexus-phase-7-visual-qa.md`. +2. **Review the audit doc's remaining follow-ups** (F4–F12, tracked but not fixed in this branch). None are blockers. Each is a small independent commit that could land as its own PR later. -1. **Phase 4 — Typography + radius audit.** Grep `rounded-xl`, `rounded-2xl`, `rounded-3xl` and bump down to `rounded-lg` (8px) or `rounded-sm` (4px). Bump display moments to `font-black` (900). Replace soft shadows with border + inset "pressed" depth. -2. **Phase 5 — ThemePreviewPanel rewrite.** `ui/src/components/ThemePreviewPanel.tsx` currently showcases Catppuccin. Rewrite against volt/forest/silver palette. Update `ThemePaletteGrid.tsx` or deprecate. -3. **Phase 6 — hljs syntax highlighting.** Replace the 3 theme rule sets in `ui/src/index.css` with a single DESIGN.md-compliant block (neon + white on dark, terminal aesthetic per §4). -4. **Phase 7 — Visual QA pass.** Walk every top-level route (Assistant, Studio, Projects, ProjectDetail, Settings, Skills, Plugins, Onboarding, Invite, Auth). Compare against DESIGN.md §3–§7. File issues as a punch list commit. +### After this branch merges -### Track B — Phase 11.5 per-project scoping (blocked on backend or extraction work) +**Track B — Phase 11.5 per-project scoping (5 tabs)** -See backlog plan `docs/plans/2026-04-11-nexus-phase-11-5-per-project-scoping.md`. 5 tabs × (extract standalone component + add `projectId` prop or backend field). Trigger: explicit UX pain or milestone pull-in. Not recommended as immediate next because it fans out into backend type changes. +See backlog plan `docs/plans/2026-04-11-nexus-phase-11-5-per-project-scoping.md`. 5 tabs × (extract standalone component + add `projectId` prop or backend field). Trigger: explicit UX pain on the placeholder tabs, or milestone pull-in. Fans out into backend type changes (`Agent.projectId`, `Approval.payload.projectId`). Should be its own branch — don't mix with the design system PR. -### Track C — Low-value follow-ups (defer until needed) +**Track C — v1.7 content-generation tail** -- Rewrite residual `/dashboard` hrefs in `SkillDetail`, `SkillBrowser`, `PluginManager`, `PluginSettings`, `PluginPage`, `NotFound`, `CompanyImport`, `ProjectDetail`, `AgentDetail`, `company-page-memory.ts`, `useCompanyPageMemory.ts` → `/assistant` or project-specific equivalents. -- Delete orphaned `ui/src/hooks/useInboxBadge.ts`. -- Dedicated vocabulary sweep for `CompanyImport.tsx` / `CompanyExport.tsx` / `CompanySkills.tsx` body copy. +All 9 Studio workshops shipped. Remaining scope is DRAFT placeholder asset styling (server-side) and any per-workshop refinement that comes out of real user sessions. -### Other possible pivots +**Track D — v1.8 Recipe Registry milestone** -- Switch back to the v1.7 content-generation milestone work (all 9 workshops shipped, remaining is DRAFT placeholder assets). -- Move to the v1.8 Recipe Registry milestone. +Planned, not yet started. Phase 14 stubbed the "Recipes" group in the command palette as a disabled placeholder. New branch, new milestone entry in `.planning/PROJECT.md`. -### Recommendation +### Phase 7 audit follow-ups (12 tracked, 4 applied F1–F3 this session) -**Tackle Track A (visual migration phases 4–7) next.** Rationale: finishes the design-system-migration branch cleanly, no cross-cutting dependencies, unblocks a clean PR for the full Wave 1–3B + 4–7 package. Phase 11.5 is better as a separate branch after this one merges. +Applied: F1 (brand color aliases), F2 (shadow-xs cleanup), F3 (DESIGN.md Inter-only amendment). + +Deferred to post-merge: F4–F12. See `docs/reviews/2026-04-11-nexus-phase-7-visual-qa.md` for the full list. None are blockers. ### Hard hazards to remember