nexus/ui/src/components/OutputFeedbackButtons.tsx
Nexus Dev 3a41ec7b9c feat(nexus): design system phase 3 raw utility sweep
Third phase of the DESIGN.md migration. Removes every raw Tailwind
color palette utility (bg-red-*, text-amber-*, border-blue-*, etc.)
from component source and replaces them with the semantic tokens
introduced in phases 1 and 2.

Scope:
  - 84 files touched under ui/src/
  - ~420 raw palette utility instances replaced
  - 23 hardcoded hex fallbacks replaced with var(--token) refs
  - Zero raw palette utilities remain in component source
    (verified with rg '(bg|text|border|ring)-(red|blue|green|amber|
    yellow|cyan|violet|purple|pink|slate|zinc|neutral|sky|teal|
    emerald|indigo|rose|orange|fuchsia)-[0-9]+' ui/src)

Mapping rules applied:
  - red-* -> destructive
  - amber-/yellow-/orange-* -> warning
  - green-/emerald-* -> success
  - blue-/cyan-/sky-* -> primary (info/in-progress) or muted-foreground
  - slate-/gray-/zinc-/neutral-* -> muted / muted-foreground / border
  - violet-/purple-/pink-/indigo-/rose-/teal-* -> collapsed to
    primary or muted (most were one-off decorative choices, not
    role-bearing). Role-bearing uses go through lib/agent-role-colors
    which was rewritten in phase 2.
  - Opacity modifiers preserved (/10, /15, /20, etc.)
  - dark: variant duplicates removed (theme tokens auto-switch)

Hardcoded hex fallbacks fixed:
  - #6366f1 (indigo) -> var(--primary) / var(--volt)
  - #64748b (slate) -> var(--muted-foreground) / var(--silver)
  - #4f46e5 (indigo) -> var(--primary)
  - #89b4fa (old Catppuccin blue) -> var(--primary) / #faff69
  - OrgChart status dots (#22d3ee/#4ade80/#facc15/#f87171/#a3a3a3)
    -> var(--primary) / var(--success) / var(--warning) /
    var(--destructive) / var(--muted-foreground) per status
  - VoiceWaveform fallback #89b4fa -> #faff69 (volt)

Legitimate hex values left untouched (12 total):
  - lib/color-contrast.ts WCAG reference constants
  - lib/worktree-branding.ts contrast fallback references
  - lib/mention-chips.ts runtime-generated SVG fills
  - context/ThemeContext.tsx theme metadata brand hexes
  - components/ThemeSeedInput.tsx user-facing hex picker

Ambiguous decisions (flagged for visual QA):
  - AgentDetail.tsx invocation-source badges (timer/assignment/
    on_demand) collapsed to primary/muted — visual distinction
    is reduced, labels still differ. Consider chart-role slots
    if differentiation matters.
  - AgentDetail.tsx mixed-opacity amber banners: bg-warning/60
    against new warning base reads heavier than original amber-50
    base.
  - Live-state dots in KanbanBoard/AgentDetail: bg-blue-* ->
    bg-primary — will glow volt in dark mode, probably desirable.

Verification:
  - npx tsc --noEmit in ui/ — zero errors introduced. Pre-existing
    errors in AgentConfigForm, command.tsx, useKeyboardShortcuts,
    usePiperTts, useVadRecorder, PersonalAssistant remain, all
    unrelated to color work.
  - Dev server on :6100 returns 200.

Not changed in this commit:
  - ui/src/lib/company-routes.ts — separate routing fix for broken
    Assistant/ContentStudio/Convert links, committed next.
  - Test files — a few will need assertion updates but are out of
    phase 3 scope.

Phase 4 follow-ups (rounded-xl/2xl collapse, soft shadow removal,
gradient removal) noted in .planning/AUDIT-RADIUS-SHADOWS.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 17:40:32 +00:00

263 lines
8.5 KiB
TypeScript

import { useEffect, useState } from "react";
import type { FeedbackDataSharingPreference, FeedbackVoteValue } from "@paperclipai/shared";
import { Button } from "@/components/ui/button";
import { Textarea } from "@/components/ui/textarea";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import { ThumbsDown, ThumbsUp } from "lucide-react";
import { cn } from "../lib/utils";
export function OutputFeedbackButtons({
activeVote,
disabled = false,
sharingPreference = "prompt",
termsUrl = null,
onVote,
rightSlot,
}: {
activeVote?: FeedbackVoteValue | null;
disabled?: boolean;
sharingPreference?: FeedbackDataSharingPreference;
termsUrl?: string | null;
onVote: (vote: FeedbackVoteValue, options?: { allowSharing?: boolean; reason?: string }) => Promise<void>;
rightSlot?: React.ReactNode;
}) {
const [pendingVote, setPendingVote] = useState<{
vote: FeedbackVoteValue;
reason?: string;
keepReasonPromptOpen?: boolean;
} | null>(null);
const [isSaving, setIsSaving] = useState(false);
const [downvoteReason, setDownvoteReason] = useState("");
const [collectingDownvoteReason, setCollectingDownvoteReason] = useState(false);
const [downvoteAllowSharing, setDownvoteAllowSharing] = useState<boolean | undefined>(undefined);
const [optimisticVote, setOptimisticVote] = useState<FeedbackVoteValue | null>(null);
const visibleVote = optimisticVote ?? activeVote ?? null;
useEffect(() => {
if (optimisticVote && activeVote === optimisticVote) {
setOptimisticVote(null);
}
}, [activeVote, optimisticVote]);
async function submitVote(
vote: FeedbackVoteValue,
options?: { allowSharing?: boolean; reason?: string },
behavior?: { keepReasonPromptOpen?: boolean },
) {
setIsSaving(true);
try {
await onVote(vote, options);
setPendingVote(null);
if (!behavior?.keepReasonPromptOpen) {
setCollectingDownvoteReason(false);
setDownvoteReason("");
setDownvoteAllowSharing(undefined);
}
} catch (error) {
setOptimisticVote(null);
throw error;
} finally {
setIsSaving(false);
}
}
function beginVote(
vote: FeedbackVoteValue,
reason?: string,
behavior?: { keepReasonPromptOpen?: boolean },
) {
if (sharingPreference === "prompt") {
setPendingVote({
vote,
...(reason ? { reason } : {}),
...(behavior?.keepReasonPromptOpen ? { keepReasonPromptOpen: true } : {}),
});
return;
}
const allowSharing = sharingPreference === "allowed";
if (vote === "down") {
setDownvoteAllowSharing(allowSharing);
}
void submitVote(
vote,
{
...(allowSharing ? { allowSharing: true } : {}),
...(reason ? { reason } : {}),
},
behavior,
);
}
function handleVote(vote: FeedbackVoteValue) {
setOptimisticVote(vote);
if (vote === "down") {
setCollectingDownvoteReason(true);
setDownvoteReason("");
setDownvoteAllowSharing(undefined);
void beginVote("down", undefined, { keepReasonPromptOpen: true });
return;
}
void beginVote(vote);
}
return (
<>
<div className="mt-3 flex items-center gap-2 border-t border-border/60 pt-3">
<Button
type="button"
size="sm"
variant="outline"
disabled={disabled || isSaving}
className={cn(visibleVote === "up" && "border-success/50 bg-success/10 text-success")}
onClick={() => handleVote("up")}
>
<ThumbsUp className="mr-1.5 h-3.5 w-3.5" />
Helpful
</Button>
<Button
type="button"
size="sm"
variant="outline"
disabled={disabled || isSaving}
className={cn(visibleVote === "down" && "border-warning/50 bg-warning/10 text-warning")}
onClick={() => handleVote("down")}
>
<ThumbsDown className="mr-1.5 h-3.5 w-3.5" />
Needs work
</Button>
{rightSlot ? <div className="ml-auto">{rightSlot}</div> : null}
</div>
{collectingDownvoteReason ? (
<div className="mt-2 rounded-md border border-border/60 bg-accent/20 p-3">
<div className="mb-2 text-sm font-medium">What could have been better?</div>
<Textarea
value={downvoteReason}
onChange={(event) => setDownvoteReason(event.target.value)}
placeholder="Add a short note"
className="min-h-20 resize-y bg-background"
disabled={disabled || isSaving}
/>
<div className="mt-3 flex items-center justify-end gap-2">
<Button
type="button"
size="sm"
variant="outline"
disabled={disabled || isSaving}
onClick={() => {
setCollectingDownvoteReason(false);
setDownvoteReason("");
setDownvoteAllowSharing(undefined);
}}
>
Dismiss
</Button>
<Button
type="button"
size="sm"
disabled={disabled || isSaving || !downvoteReason.trim()}
onClick={() => {
void submitVote("down", {
...(downvoteAllowSharing ? { allowSharing: true } : {}),
reason: downvoteReason,
});
}}
>
{isSaving ? "Saving..." : "Save note"}
</Button>
</div>
</div>
) : null}
<Dialog
open={Boolean(pendingVote)}
onOpenChange={(open) => {
if (!open && !isSaving) {
setPendingVote(null);
setOptimisticVote(null);
}
}}
>
<DialogContent>
<DialogHeader>
<DialogTitle>Save your feedback sharing preference</DialogTitle>
<DialogDescription>
Choose whether voted AI outputs can be shared with Paperclip Labs. This
answer becomes the default for future thumbs up and thumbs down votes.
</DialogDescription>
</DialogHeader>
<div className="space-y-3 text-sm text-muted-foreground">
<p>
This vote is always saved locally.
</p>
<p>
Choose <span className="font-medium text-foreground">Always allow</span> to share
this vote and future voted AI outputs. Choose{" "}
<span className="font-medium text-foreground">Don't allow</span> to keep this vote
and future votes local.
</p>
<p>
You can change this later in Instance Settings &gt; General.
</p>
{termsUrl ? (
<a
href={termsUrl}
target="_blank"
rel="noreferrer"
className="inline-flex text-sm text-foreground underline underline-offset-4"
>
Read our terms of service
</a>
) : null}
</div>
<DialogFooter>
<Button
type="button"
variant="outline"
disabled={!pendingVote || isSaving}
onClick={() => {
if (!pendingVote) return;
if (pendingVote.vote === "down") {
setDownvoteAllowSharing(false);
}
void submitVote(
pendingVote.vote,
pendingVote.reason ? { reason: pendingVote.reason } : undefined,
{ keepReasonPromptOpen: pendingVote.keepReasonPromptOpen },
);
}}
>
{isSaving ? "Saving..." : "Don't allow"}
</Button>
<Button
type="button"
disabled={!pendingVote || isSaving}
onClick={() => {
if (!pendingVote) return;
if (pendingVote.vote === "down") {
setDownvoteAllowSharing(true);
}
void submitVote(
pendingVote.vote,
{
allowSharing: true,
...(pendingVote.reason ? { reason: pendingVote.reason } : {}),
},
{ keepReasonPromptOpen: pendingVote.keepReasonPromptOpen },
);
}}
>
{isSaving ? "Saving..." : "Always allow"}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</>
);
}