35 lines
2.3 KiB
Markdown
35 lines
2.3 KiB
Markdown
# Phase 41 Deferred Items
|
|
|
|
Pre-existing issues discovered during Phase 41-06 verification. These are out-of-scope and should be addressed in maintenance tasks.
|
|
|
|
## Pre-existing Server Test Failures (4 files, 19 tests)
|
|
|
|
1. **`30-hardware-detection.test.ts`** — nexusSettingsService default returns `{ mode, voiceEnabled, voiceMode }` but test expects `{ mode: 'both' }` only. voiceEnabled/voiceMode defaults were added in phases 30-01/36-02 but the test was never updated. Fix: update test to use `expect(settings.mode).toBe('both')` and `expect(settings).toMatchObject({ mode: 'both' })`.
|
|
|
|
2. **`heartbeat-workspace-session.test.ts`** (11 failures) — Tests import `deriveTaskKeyWithHeartbeatFallback` from heartbeat-workspace-session.ts but function is not exported. Also `applyPersistedExecutionWorkspaceConfig` and `buildRealizedExecutionWorkspaceFromPersisted` test failures from upstream changes.
|
|
|
|
3. **`agent-permissions-routes.test.ts`** — Mine tab route (`GET /api/agents/:agentId/issues/mine`) returns 404/400 instead of 200. Route handler incomplete from upstream PAP-878 feature.
|
|
|
|
4. **`skill-registry-routes.test.ts`** (5 failures) — Route parameter mismatch: tests send `agentSkillsDir` but handler expects `agentId`. Also DELETE endpoint returning 400.
|
|
|
|
## Pre-existing UI TypeScript Errors (6 errors in 5 files)
|
|
|
|
1. **`AgentConfigForm.tsx:351`** — `agentsApi.detectModel` doesn't exist. Method was likely removed from agentsApi during a refactor.
|
|
|
|
2. **`useKeyboardShortcuts.ts:25`** — `onSearch` referenced but not defined. Missing parameter or closure variable.
|
|
|
|
3. **`useNexusMode.ts:14`** — `queryKeys.nexus` property doesn't exist in queryKeys object.
|
|
|
|
4. **`usePiperTts.ts:2`** — `tts` not exported from `@mintplex-labs/piper-tts-web`. Package API changed.
|
|
|
|
5. **`useVadRecorder.ts:58`** — `redemptionFrames` should be `redemptionMs` in VAD options type.
|
|
|
|
6. **`PersonalAssistant.tsx:231,234`** — `"positive"` and `"critical"` are not valid `ToastTone` values. Toast API changed.
|
|
|
|
## Pre-existing Build Failure
|
|
|
|
- **`packages/db` duplicate migration** — `0046_smooth_sentinels.sql` (from upstream) and `0046_tense_randall.sql` (from Phase 40) conflict. Fix: renumber Phase 40 migration to `0047_tense_randall.sql`.
|
|
|
|
---
|
|
*Discovered during: Phase 41-06 verification (2026-04-04)*
|
|
*Phase that caused each issue: noted above*
|